On Wed, 2018-09-19 at 21:49 +0200, Johannes Berg wrote: > > case NLA_REJECT: > - if (pt->validation_data && error_msg) > - *error_msg = pt->validation_data; > + NL_SET_BAD_ATTR(extack, nla); > + if (extack && pt->validation_data) > + extack->_msg = pt->validation_data; > return -EINVAL; Damn. This of course needs to happen only if pt->validation_data is set, otherwise it needs to "goto out_err" to set the default message. I'll respin another day with that fixed, and any other comments that come in until then addressed. Sorry for the noise :-( johannes
