On 9/19/18 5:08 AM, Johannes Berg wrote: > diff --git a/lib/nlattr.c b/lib/nlattr.c > index 966cd3dcf31b..2b015e43b725 100644 > --- a/lib/nlattr.c > +++ b/lib/nlattr.c > @@ -69,7 +69,7 @@ static int validate_nla_bitfield32(const struct nlattr *nla, > > static int validate_nla(const struct nlattr *nla, int maxtype, > const struct nla_policy *policy, > - const char **error_msg) > + struct netlink_ext_ack *extack, bool *extack_set) extack_set arg is not needed if you handle the "Attribute failed policy validation" message and NL_SET_BAD_ATTR here as well.