On Wed, 2018-09-12 at 10:36 +0200, Johannes Berg wrote: > @@ -251,7 +257,7 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head, > > if (type > 0 && type <= maxtype) { > if (policy) { > - err = validate_nla(nla, maxtype, policy); > + err = validate_nla(nla, maxtype, policy, extack); > if (err < 0) { > NL_SET_ERR_MSG_ATTR(extack, nla, > "Attribute failed policy validation"); Err... I should read my patches before sending them :-) Clearly, this NL_SET_ERR_MSG_ATTR() overwrites the error message, so would have to be made conditional. I can fix that (and I should use/test it) if we decide it's worthwhile. johannes