Search Linux Wireless

Re: [PATCH 4.19] mt76x0: fix remove_interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes:

> On Mon, Sep 03, 2018 at 09:36:37AM -0400, Sid Hayn wrote:
>> Best I can say is that it seemed to happen after a failed connection.  It
>> would connect and disconnect a few times and work fine, but if it failed to
>> connect for any reason (mostly mismatched settings between AP and
>> wpa_supplicant.conf) then the bug would occur. So, wpa_supplicant would up
>> the interface, try to connect, fail, down the interface and exit, then the
>> next loop of my script (with a different conf file) would start and
>> wpa_supplicant would be unable to up the interface.
> <snip>
>> > For bug fixes please always try to describe the bug and symptoms. I can
>> > add it this time. From the other thread I saw that 'ifconfig up' failed
>> > like this:
>> >
>> > SIOCSIFFLAGS: No space left on device
>> >
>> > But in what cases did that happen? (I assume not always)
>
> Problem will happen when we remove interface more than 8 times.
> I'm not sure at how this can be triggerd execpt by doing:
>
> iw dev <devname> interface add <name> type <type>
> iw dev <name> del
>
> but looks somehow this is triggerd by Sid scripts
> by just by using wpa_supplicant and ifconfig. 

Good, thanks. So I'll use this as the commit message:

"We wrongly use wcid_mask instead of vif_mask. This creates problems
when the interface is removed more than 8 times, for example with iw:

iw dev <devname> interface add <name> type <type>
iw dev <name> del

This caused 'ifconfig up' to fail with error:

SIOCSIFFLAGS: No space left on device"

Does that look good?

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux