On 2018-09-06 12:43, Stanislaw Gruszka wrote: > On Thu, Sep 06, 2018 at 11:33:55AM +0200, Felix Fietkau wrote: >> On 2018-09-06 11:18, Stanislaw Gruszka wrote: >> > Move some irq handling code to generic mmio module. >> > >> > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> >> Please drop this patch. This won't work on MT7603 and later. > > Yeah, I thought MT_INT_MASK_CSR is the same 0x0204 for all chips, > but for MT7603 this is MT_HIF(0x204). I assume we can still unify > irq_lock, irqmask fields in common structure. > > Anyway would be good to have mt7603 driver unstreamed, so we could > easily see what can be shared in mt76 generic code for all chips. > > Felix, do you have plans to upstream it? Want some help with that ? I plan on sending it upstream soon. It's still not fully stable, but that shouldn't be a blocker. - Felix
