On Thu, Sep 06, 2018 at 11:47:53AM +0200, Lorenzo Bianconi wrote: > > > > On 2018-09-06 11:37, Lorenzo Bianconi wrote: > > >> > > >> On 2018-09-06 11:18, Stanislaw Gruszka wrote: > > >> > Move some irq handling code to generic mmio module. > > >> > > > >> > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > >> Please drop this patch. This won't work on MT7603 and later. > > >> > > >> - Felix > > > > > > I can move that code in a dedicated module with a separated patch. > > > I have a pending patchset to fix that kind of issues for usb as well. > > > Does it sound good? > > I don't think it's worth having yet another dedicated module for these > > small things. Just keep it in the common mt76x02 code, even if it > > doesn't get used by the usb variants. > > > > - Felix > > Ack, I agree. I guess Stanislaw can fix it sending a v2 Actually those two patches can be dropped from the set, remainging 40,41,42 patches will apply. Kalle plese drop: [PATCH 38/42] mt76: initial separation of mmio part [PATCH 39/42] mt76: move some irq code to common mmio module Thanks Stanislaw