On Thu, 2018-09-06 at 16:22 +0800, Hao Wei Tee wrote:
> Hi,
Hi Hao Wei,
> On 21/8/18 2:36 PM, Luca Coelho wrote:
> > From: Avraham Stern <avraham.stern@xxxxxxxxx>
> >
> > The parameter that indicated whether the LQ command should be sent
> > as sync or async was removed, causing the LQ command to be sent as
> > sync from interrupt context (e.g. from the RX path). This resulted
> > in a kernel warning: "scheduling while atomic" and failing to send
> > the LQ command, which ultimately leads to a queue hang.
> >
> > Fix it by adding back the required parameter to send the command as
> > sync only when it is allowed.
> >
> > Fixes: d94c5a820d10 ("iwlwifi: mvm: open BA session only when sta is authorized")
> > Signed-off-by: Avraham Stern <avraham.stern@xxxxxxxxx>
> > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
>
> I'm not sure whether you guys normally send fixes to stable, but this
> really should go to stable. I run into this bug as often as a few times
> an hour and sometimes it leads to IRQs from other devices being dropped
> (e.g. touchpad, in turn causing the driver to timeout and quit, and the
> touchpad dies).
We do send things for stable and the "Fixes" tag included in this patch
will cause it to be automatically considered for the stable releases
that contain the commit it points to. So we should be fine here.
If you notice that, for some reason, this doesn't end up applied in the
specific stable kernel you need it on, please let us know and we'll
check it out. Also note that anyone can suggest any patch to stable
releases, there's a process[1] in place for that.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst
Thanks for your contribution!
--
Cheers,
Luca.
