On Wed, 2018-09-05 at 11:56 +0200, Toke Høiland-Jørgensen wrote: > > So basically this gets rid of a corner case that we shouldn't have. > > Either we should decide that using different TXQs is *always* correct > > for non-QoS, or - what I thought - that this isn't worth it, and then we > > should *never* do it. > > Yeah, I agree that this is not worth it. The queue is already > FQ-CoDel'ed, which gives us most of the benefit of QoS anyway :) So do I read that as a tentative ack? :) Felix wasn't really convinced, I think. He also pointed out some drivers use skb->priority without checking anything, but I'm not sure we can really squash all the cases of setting skb priority easily? johannes
