Re: [PATCH 4/4] ath10k: add debugfs support to dump per sta tx stats

Anilkumar Kolli <akolli@xxxxxxxxxxxxxx> · Tue, 04 Sep 2018 14:24:06 +0530

On 2018-08-28 19:06, Kalle Valo wrote:
Anilkumar Kolli <akolli@xxxxxxxxxxxxxx> wrote:

This patch adds 'tx_stats' in per station debugfs entry.

Use this command to dump tx_stats:
cat /sys/kernel/debug/ieee80211/phy0/netdev\:wlan0/
    stations/<MACADDR>/tx_stats

Signed-off-by: Anilkumar Kolli <akolli@xxxxxxxxxxxxxx>
Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

kbuild bot found new warnings:

   drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function
'ath10k_dbg_sta_dump_tx_stats':
drivers/net/wireless/ath/ath10k/debugfs_sta.c:714:1: warning: the 
frame size of 1088 bytes is larger than 1024 bytes 
[-Wframe-larger-than=]
    }
    ^

   drivers/net/wireless/ath/ath10k/debugfs_sta.c: In function
'ath10k_sta_add_debugfs':
drivers/net/wireless/ath/ath10k/debugfs_sta.c:737:41: error: 'struct 
ath10k' has no member named 'debug'
     if (ath10k_peer_stats_enabled(ar) && 
ar->debug.enable_extd_tx_stats)
                                            ^~

Please drop this patch series, I sent V2 addressing these issues.

Thanks
Anil.