Search Linux Wireless

Re: [PATCH 1/2] mwifiex: do no submit URB in suspended state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ganapathi Bhat <gbhat@xxxxxxxxxxx> wrote:

> There is a possible race between USB suspend and main thread:
> 
> 1. After processing the command response, main thread will submit
> rx_cmd URB back so as to process next command response, by
> calling mwifiex_usb_submit_rx_urb.
> 
> 2. During USB suspend, the suspend handler will check if rx_cmd
> URB is pending(submitted) and if true, kill this URB.
> 
> There is a possible race between #1 and #2, where rx_cmd URB will
> be submitted by main thread(#1) after the suspend handler check
> in #2.
> 
> To fix this, check if device is already suspended in
> mwifiex_usb_submit_rx_urb, in which case do not submit the URB.
> 
> Signed-off-by: Vidya Dharmaraju <vidyad@xxxxxxxxxxx>
> Signed-off-by: Cathy Luo <cluo@xxxxxxxxxxx>
> Signed-off-by: Ganapathi Bhat <gbhat@xxxxxxxxxxx>

2 patches applied to wireless-drivers-next.git, thanks.

7bd4628c2f31 mwifiex: do no submit URB in suspended state
33a164fa8a4c mwifex: free rx_cmd skb in suspended state

-- 
https://patchwork.kernel.org/patch/10571161/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux