Search Linux Wireless

Re: [PATCH] mac80211: do not aggregate frames if max_frags is set to one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-08-28 at 23:07 +0200, Lorenzo Bianconi wrote:
> Do not try to aggregate packets in a A-MSDU frame if max_tx_fragments
> or max_amsdu_subframes is set to 1. 

Yeah that seems valid.

> Moreover take into account
> tail padding added on the first frame into flow backlog if
> ieee80211_amsdu_realloc_pad routine on the second frame fails.

That's not really right - the padding shouldn't have been added to the
first subframe in the first place as the last one shouldn't have padding
at all. There's also a separate bug in that the A-MSDU subframe length
should NOT include the padding.

My colleague Sara (CC'ed now) has a patch to fix all of this (we just
did that this morning). I'll send it out tomorrow morning. Can I bother
you to try that?

We'd have to fix the first point independently though, or I guess we can
roll that into our bugfix too, which would you prefer?

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux