Hi Govind, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v4.19-rc1 next-20180828] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Govind-Singh/ath10k-Enable-pktlog-for-WCN3990-chipset/20180828-154302 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/net/wireless/ath/ath10k/htc.c:498:25: sparse: expression using sizeof(void) drivers/net/wireless/ath/ath10k/htc.c:657:25: sparse: expression using sizeof(void) >> drivers/net/wireless/ath/ath10k/htc.c:875:6: sparse: symbol 'ath10k_htc_pktlog_svc_supported' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation