Search Linux Wireless

Re: [PATCH 02/17] mt76: rename mt76x2_regs.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 25, 2018 at 01:56:47PM +0200, Felix Fietkau wrote:
> >> I think mt76xx_regs.h is named too generic. MT7603, MT7628, MT7615 and
> >> all newer chips use a completely different register layout.
> >> I'd prefer to stick with mt76x2_regs for now and use it for x0 as well.
> > 
> > I thought about that too, but choose it will be better to have some
> > prefix that will indicate the function/structure/header is shared between
> > the x0 and x2 drivers to not confuse mt76x2 code that is mt76x2 only
> > and one that is shared.
> > 
> > I choose mt76xx name, considered mt76 to be generic prefix shared also 
> > between old and new chips. But yeah this mt76xx name also "contains" new
> > chips. How about mt76old_ or mt76og_ (old generation) ?
> I think this looks even more confusing. Also, please keep in mind that
> 'old' is relative as well.
> How about mt76x02?

Ok to me. 

Stanislaw



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux