On Wed, 2018-08-22 at 11:45 +0900, Byungchul Park wrote: > That should've been adjusted as well when Ingo reverted Cross-release. I can't really say. > It would be much easier to add each pair, acquire/release, before > wait_for_completion() in both flush_workqueue() and flush_work() than > reverting the whole commit. The commit doesn't do much more than this though. > What's lacking is only lockdep annotations for wait_for_completion(). No, I disagree. Like I said before, we need the lockdep annotations on the WQ even when we don't actually create/use the completion, so we can catch issues even when they don't actually happen. johannes
