On 2018-08-20 14:05, Kalle Valo wrote: > Felix Fietkau <nbd@xxxxxxxx> writes: > >> Tx99 is typically configured via a monitor mode interface, which does >> not get added to the driver as a vif. Since the code currently expects >> a configured virtual interface for tx99, enabling tx99 via debugfs fails. >> Since the vif is not needed anyway, remove all checks for it. >> >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxx> > > [...] > >> --- a/drivers/net/wireless/ath/ath9k/main.c >> +++ b/drivers/net/wireless/ath/ath9k/main.c >> @@ -1251,15 +1251,10 @@ static int ath9k_add_interface(struct ieee80211_hw *hw, >> struct ath_vif *avp = (void *)vif->drv_priv; >> struct ath_node *an = &avp->mcast_node; >> >> - mutex_lock(&sc->mutex); >> + if (IS_ENABLED(CPTCFG_ATH9K_TX99)) >> + return -EOPNOTSUPP; > > Obviously this should be CONFIG_ATH9K_TX99, I'll fix that in the pending > branch. Sorry about that, I'll be more careful next time. Thanks, - Felix
