Search Linux Wireless

Re: [PATCH] ath10k: support NET_DETECT WoWLAN feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ath6kl/ath-next]
[also build test WARNING on v4.18 next-20180813]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Wen-Gong/ath10k-support-NET_DETECT-WoWLAN-feature/20180814-174257
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/net/wireless/ath/ath10k/wow.c: In function 'ath10k_wow_op_resume':
>> drivers/net/wireless/ath/ath10k/wow.c:451:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (ret) {
         ^
   drivers/net/wireless/ath/ath10k/wow.c:421:6: note: 'ret' was declared here
     int ret;
         ^~~

vim +/ret +451 drivers/net/wireless/ath/ath10k/wow.c

   441	
   442	static int ath10k_wow_nlo_cleanup(struct ath10k *ar)
   443	{
   444		struct ath10k_vif *arvif;
   445		int ret;
   446	
   447		lockdep_assert_held(&ar->conf_mutex);
   448	
   449		list_for_each_entry(arvif, &ar->arvifs, list) {
   450			ret = ath10k_vif_wow_clean_nlo(arvif);
 > 451			if (ret) {
   452				ath10k_warn(ar, "failed to clean nlo settings on vdev %i: %d\n",
   453					    arvif->vdev_id, ret);
   454				return ret;
   455			}
   456		}
   457	
   458		return 0;
   459	}
   460	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux