Hi Greg,
On Sun, 12 Aug 2018 13:29:30 +0200
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Aug 12, 2018 at 10:17:41AM +0530, Ajay Singh wrote:
> > Refactor code by removing array of 'wilc_debugfs_info_t' type and
> > use single variable to store 'wilc_debugfs_info_t' struct value.
> >
> > Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
> > ---
> > drivers/staging/wilc1000/wilc_debugfs.c | 26
> > +++++++++----------------- 1 file changed, 9 insertions(+), 17
> > deletions(-)
> >
> > diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
> > b/drivers/staging/wilc1000/wilc_debugfs.c index edc7287..c5f67c9
> > 100644 --- a/drivers/staging/wilc1000/wilc_debugfs.c
> > +++ b/drivers/staging/wilc1000/wilc_debugfs.c
> > @@ -78,29 +78,21 @@ struct wilc_debugfs_info_t {
> > const struct file_operations fops;
> > };
> >
> > -static struct wilc_debugfs_info_t debugfs_info[] = {
> > - {
> > - "wilc_debug_level",
> > - 0666,
> > - (DEBUG | ERR),
> > - FOPS(NULL, wilc_debug_level_read,
> > wilc_debug_level_write, NULL),
> > - },
> > +static struct wilc_debugfs_info_t debugfs_info = {
> > + "wilc_debug_level",
> > + 0666,
> > + (DEBUG | ERR),
> > + FOPS(NULL, wilc_debug_level_read, wilc_debug_level_write,
> > NULL), };
> >
> > int wilc_debugfs_init(void)
> > {
> > - int i;
> > - struct wilc_debugfs_info_t *info;
> > + struct wilc_debugfs_info_t *info = &debugfs_info;
> >
> > wilc_dir = debugfs_create_dir("wilc_wifi", NULL);
> > - for (i = 0; i < ARRAY_SIZE(debugfs_info); i++) {
> > - info = &debugfs_info[i];
> > - debugfs_create_file(info->name,
> > - info->perm,
> > - wilc_dir,
> > - &info->data,
> > - &info->fops);
> > - }
> > + debugfs_create_file(info->name, info->perm, wilc_dir,
> > &info->data,
> > + &info->fops);
> > +
>
> Why go through the extra step here in changing this variable from an
> array to a single value and not just make the call to
> debugfs_create_file() directly with the individual values like you do
> in patch 3? It feels like this step isn't needed at all here, right?
>
> What am I missing?
Actually, while calling debugfs_create_file() it also passed the
"info->data", "info->perm" which was maintained in a static variable.
So to have the changes in multiple patches, I first tried by removing
the dependency of array and later changed the individual parameters
for this debugfs_create_file().
Regards
Ajay
