On Sun, Aug 12, 2018 at 04:52:04PM +0530, Ajay Singh wrote:
> Hi Greg,
>
> On Sun, 12 Aug 2018 08:42:50 +0200
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Sun, Aug 12, 2018 at 10:17:42AM +0530, Ajay Singh wrote:
> > > wilc_debug.o object file is included for both SDIO and SPI module.
> > > When anyone(either SDIO or SPI) module is compiled as loaded module
> > > and another as buildin module then below compilation error occurs.
> > >
> > > "drivers/staging/wilc1000/wilc_debugfs.o:(.data+0x10): undefined
> > > reference to `__this_module'"
> > >
> > > Moved the declaration of file_operation variable in SDIO/SPI files
> > > and pass this as parameter to wilc_debugfs_init(). Remove 'fops'
> > > element from 'wilc_debugfs_info_t' struct, as its not required.
> > >
> > > Fixes: 9abc44ba4e2f ("staging: wilc1000: fix TODO to compile spi
> > > and sdio components in single module") Reported-by: kbuild test
> > > robot <lkp@xxxxxxxxx> Signed-off-by: Ajay Singh
> > > <ajay.kathat@xxxxxxxxxxxxx> ---
> >
> > Can this be the first patch in the series so it can go to Linus for
> > 4.19 and the rest can be postponed for later?
> >
>
> No, the patches are in order. To apply this patch the first patch has
> to be also applied.
>
> If its okay, I can merge the first 2 patches and give a single patch
> so it can be sent for 4.19 release. Rest of the patches can be
> postponed for later.
No, no need for merging them, I'll just split them up that way then, I
was just hoping for a simpler path toward getting this fixed. I'll work
on this after 4.19-rc1 is out.
thanks,
greg k-h
