On 08/02/2018 12:45 PM, Toke Høiland-Jørgensen wrote:
Ben Greear <greearb@xxxxxxxxxxxxxxx> writes:
This is from my hacked kernel, could be my fault. I thought the fq
guys might want to know however...
Hmm, nothing obvious comes to mind; fq_flow_dequeue() just dequeues a
packet from the queue; it only has two memory derefs, to fq->lock and
flow->queue. Don't see why either of those should be freed at this
point.
Unless fq_adjust_removal() is being inlined, perhaps? Then I suppose the
flow->tin reference could be the problem, if the txq_info struct was
already freed; did you change anything around the handling of TXQs?
I have worked on some stuff to fix other leaks and corruptions in ath10k related
to txqs, maybe that is part of this problem. My full tree is here:
https://github.com/greearb/linux-ct-4.16
This bug in question is fairly repeatable on my current setup, which is high speed
tx + rx on a 9984 NIC, with buggy firmware that crashes often in the tx
path. I think the crash only happens when I rmmod the driver under
load, but possibly some of the fw crash cleanup logic that ran previously
is also involved.
I'll get the FW fixed sooner or later and quite reloading modules, and then this
problem will probably go away.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
