On Tue, Jul 31, 2018 at 10:38 AM Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:
On 07/31/2018 05:11 AM, Venkateswara Naralasetty wrote:
> Channel active/busy time are showing incorrect(less than previous or
> sometimes zero) for successive survey dump command.
>
> example:
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 54995 ms
> channel busy time: 432 ms
> channel receive time: 0 ms
> channel transmit time: 59 ms
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 32592 ms
> channel busy time: 254 ms
> channel receive time: 0 ms
> channel transmit time: 0 ms
>
> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
> as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in
> FW and send survey data to driver upon the driver request. Wrap around
> is taken care by FW.
>
> hardware used : QCA9984
> firmware ver : ver 10.4-3.5.3-00057
Have you tested this on other firmwares? I am pretty sure that at least
some of them, probably 10.2, will have issues.
Maybe you could make this change specific to certain firmware that
is known to work with the change?
There are bigger problems with it than that; even with firmwares that behave correctly,
this changes the behavior that a lot of upper-layer software depends upon, and will likely
make anything that actually uses the channel survey data misbehave.
It is therefore a breaking change for any device that actually implements ACS.
-J.
