On Thu, Jul 10, 2008 at 12:10 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > Was just running sparse for something unrelated and noticed these: > > drivers/net/wireless/iwlwifi/iwl-rx.c:832:2: warning: cast truncates bits from constant value (1c00 becomes 0) > drivers/net/wireless/iwlwifi/iwl-rx.c:836:2: warning: cast truncates bits from constant value (6f080000 becomes 0) > drivers/net/wireless/iwlwifi/iwl-rx.c:836:2: warning: cast truncates bits from constant value (6f080000 becomes 0) > drivers/net/wireless/iwlwifi/iwl-rx.c:856:3: warning: cast truncates bits from constant value (4001 becomes 1) > drivers/net/wireless/iwlwifi/iwl-rx.c:860:3: warning: cast truncates bits from constant value (a000 becomes 0) > drivers/net/wireless/iwlwifi/iwl-rx.c:864:3: warning: cast truncates bits from constant value (c000 becomes 0) Yeah I've actually wanted to ask someone how to solve. This comes from radio tap code, frankly currently very low priority on my list. Not sure why but only calling directly to put_unalinged_le32 fixes this warning. In general put_unaligned should be expanded to this macro. I will submit patch that solves this. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
