Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxx> writes: >>> A simple change in argument may break algo. What would be seqno of >>> first packet of txq if queue_skb() isn't reset seqno? >> >> It would be 0, which would be less than the current seqno in all cases >> except just when the seqno counter wraps. >> > > One point should be mentioned in comment section of next_txq() that > the driver has to ensure that next_txq() iteration is serialized i.e > no parallel txq traversal are encouraged. Though txqs_list is maintained > in mac80211, parallel iteration may change the behavior. For example > I thought of get rid of txqs_lock in ath10k as txqs_list is moved to > mac80211. > But it is still needed. right? Hmm, the driver really shouldn't need to do any locking apart from using the next_txq() API. But I think you are right that the seqno mechanism doesn't play well with unserialised access to through next_txq() from multiple CPUs. I'll see what I can do about that, and also incorporate the other changes we've been discussing into a new RFC series. > Hmm.. reorder_txq() API may not needed. Calling next_txq() takes care > of reordering list though the driver is accessing txqs directly. Right, as long as the next_txq() path is still called even while fetch_ind() is active, that should be fine. >>> If we don't handle this case, then ath10k driver can not claim >>> mac80211 ATF support. Agree that MU-MIMO won't work with DDR >>> scheduler. and it will impact MU-MIMO performace in ath10k when >>> mac80211 ATF is claimed by ath10k. >> >> Yeah, so the question is if this is an acceptable tradeoff? Do you have >> any idea how often MU-MIMO actually provides a benefit in the real >> world? >> > Hmm.. We have some criteria of ~1.9 gain in Mu-MIMO test cases with 50 > 11ac clients. Hmm, yeah, that would be a shame to lose; although I do think 50-client deployments are still relatively rare for many people. So maybe we can make airtime fairness something that can be switched on and off for ath10k, depending on whether users think they will be needing MU-MIMO? Until we come up with a scheduler that can handle it, of course... -Toke
