On 2018/7/27 17:25, Kalle Valo wrote: > Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > >> + Randy >> >> On 7/13/2018 9:03 AM, YueHaibing wrote: >>> When CONFIG_PROC_FS isn't set, gcc warning this: >>> >>> drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: ‘prism2_registers_proc_show’ defined but not used [-Wunused-function] >>> static int prism2_registers_proc_show(struct seq_file *m, void *v) >>> >>> drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: ‘prism2_debug_proc_show’ defined but not used [-Wunused-function] >>> static int prism2_debug_proc_show(struct seq_file *m, void *v) >>> ^ >>> drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: ‘prism2_stats_proc_show’ defined but not used [-Wunused-function] >>> static int prism2_stats_proc_show(struct seq_file *m, void *v) >>> ^ >>> drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: ‘prism2_crypt_proc_show’ defined but not used [-Wunused-function] >>> static int prism2_crypt_proc_show(struct seq_file *m, void *v) >>> ^ >>> >>> fix this by adding #ifdef around them. >>> hfa384x_read_reg is only used by prism2_registers_proc_show,so move it >>> into #ifdef. >> >> There was already a fix for this posted by Randy Dunlap taking a >> different approach, ie. use __maybe_unused classifier. To be honest I >> prefer the ifdef approach as it is more explicit and does not feel >> like a cheat. > > I also prefer the ifdef approach more so I'm planning to take this > patch. It's ok if you prefer pick this. >
