Search Linux Wireless

Re: [PATCH] libertas: fix memory alignment problems on the blackfin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 9, 2008 at 11:07 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2008-07-09 at 23:03 +0300, Ihar Hrachyshka wrote:
>> On Wed, Jul 9, 2008 at 4:21 PM, Holger Schurig
>> <hs4233@xxxxxxxxxxxxxxxxxxxx> wrote:
>> >> Fixing unaligned memory access on the blackfin architecture
>> >> (maybe on the ARM also).
>> >
>> > You can delete the "maybe", on ARM (more specificially, on a
>> > PXA255, which is ARMv5TE) I didn't had a problem.
>>
>> Ok, just blackfin. Is it a joke or should I resend the patch with
>> another description?..
>
> I'm sure arm has that problem too and sparc and others, but it may not
> always show up because the frame might actually be aligned sometimes.
>
> OTOH, why are you getting unaligned frames in the first place? This is
> the beacon interval, so it's at a fixed modulo-two position from the
> start of the frame.

Do you mean that we should add __attribute__ ((aligned (2))) for our
'bss_descriptor' structure definition rather align particular fields
at runtime?

>
> johannes
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux