> > Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> writes: > > > On Jul 05, Stanislaw Gruszka wrote: > >> Add usb files of mt76x0 driver. > >> > >> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > [...] > > >> +static int mt76x0_suspend(struct usb_interface *usb_intf, pm_message_t state) > >> +{ > >> + struct mt76x0_dev *dev = usb_get_intfdata(usb_intf); > >> + > >> + mt76x0_cleanup(dev); > > > > Is it necessary to deallocate rx queue here in case of a system suspend? > > BTW it would really helpful to others if you could edit your quotes. It > takes some time to find your oneliner from a 450 line message. Ack sorry, I will be more verbose next time :). I mean that AFAIU it is not necessary to deallocate all buffers in the rx queue during suspend/resume (using mt76x0_cleanup routine) but we can just mark them as 'free' and reuse them as soon as the hw is resumed. I guess the same approach can be used for mcu rx buffer. Regards, Lorenzo > > -- > Kalle Valo