On Wed, 2008-07-09 at 09:44 +0200, Johannes Berg wrote: > > --- a/net/mac80211/wep.c > > +++ b/net/mac80211/wep.c > > @@ -291,9 +291,10 @@ u8 * ieee80211_wep_is_weak_iv(struct sk_buff *skb, struct ieee80211_key *key) > > ieee80211_rx_result > > ieee80211_crypto_wep_decrypt(struct ieee80211_rx_data *rx) > > { > > - if ((rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA && > > - ((rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_MGMT || > > - (rx->fc & IEEE80211_FCTL_STYPE) != IEEE80211_STYPE_AUTH)) > > + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)rx->skb->data; > > + > > + if (ieee80211_is_data(hdr->frame_control) && > > + ieee80211_is_auth(hdr->frame_control)) > > return RX_CONTINUE; > > That one seems impossible to hit now and should be !is_data && !is_auth > I think. Yep. I'll have another look over this to see if I made any others. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html