On 7/10/2018 8:52 PM, Toke Høiland-Jørgensen wrote:
Manikanta Pubbisetty <mpubbise@xxxxxxxxxxxxxx> writes:
On 7/10/2018 6:28 PM, Toke Høiland-Jørgensen wrote:
diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
index 172aeae..d07f7f9 100644
--- a/net/mac80211/ieee80211_i.h
+++ b/net/mac80211/ieee80211_i.h
@@ -818,6 +818,7 @@ enum txq_info_flags {
IEEE80211_TXQ_STOP,
IEEE80211_TXQ_AMPDU,
IEEE80211_TXQ_NO_AMSDU,
+ IEEE80211_TXQ_PAUSED,
};
I think it would be a good idea to either rename the flags, or at least
add an explanation somewhere of the difference between a paused and a
stopped queue...
Initially, the idea was to use IEEE80211_TXQ_STOP flag to indicate that
iTXQs are stopped; since this flag was used in the aggregation code, I
was unsure whether the same flag can be used to indicate the iTXQ stop
condition.
I could not find any better name for this:-).
Hmm, yeah, not sure whether the two code paths can stomp on each other
if you reuse the flag. It would be neat to be able to reuse it, though...
Otherwise, how about renaming the old one to _STOP_AGGR and calling the
new one _STOP_NETIF or something?
These ones are much better, thanks toke!!
I would probably like to extend the name to _STOP_NETIF_TX; how about
keeping the old one as is and renaming _TXQ_PAUSED to _TXQ_STOP_NETIF_TX ?
-Manikanta
