Search Linux Wireless

Re: [PATCH 1/3] mac80211: Include sequence number in IBSS and Mesh beacons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 09 July 2008 17:08:04 Ivo van Doorn wrote:
> On Wednesday 09 July 2008, Johannes Berg wrote:
> > 
> > > If rt2x00 would use a global lock to block all TX and beacons, then yes.
> > > But rt2x00 uses per-queue locking. When a beacon is being updated rt2x00
> > > will still allow regular frames to be queued.
> > 
> > That just widens the window. And if you have multiple queues then you
> > can't do sw sequence numbers anyway because the hardware might reorder
> > the frames.
> 
> That doesn't seem to be a problem in the legacy drivers, so I guess the hardware
> does *something* to prevent problems.

Well, legacy drivers don't use mac80211. Sequence counting can trivially be fixed
by doing it _right_ before queueing the packet to the hardware in the driver,
with the TX queue lock held, that must already be there.

-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux