On Sun, 2018-07-08 at 11:30 -0500, Larry Finger wrote: > On 07/06/2018 12:44 AM, pkshih@xxxxxxxxxxx wrote: > > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > > > RTL8822be can't bring up properly on ASUS X530UN, and dmesg says: > > [ 8.591333] r8822be: module is from the staging directory, the quality > > is unknown, you have been warned. > > [ 8.593122] r8822be 0000:02:00.0: enabling device (0000 -> 0003) > > [ 8.669163] r8822be: Using firmware rtlwifi/rtl8822befw.bin > > [ 9.289939] r8822be: rtlwifi: wireless switch is on > > [ 10.056426] r8822be 0000:02:00.0 wlp2s0: renamed from wlan0 > > ... > > [ 11.952534] r8822be: halmac_init_hal failed > > [ 11.955933] r8822be: halmac_init_hal failed > > [ 11.956227] r8822be: halmac_init_hal failed > > [ 22.007942] r8822be: halmac_init_hal failed > > > > Jian-Hong reported it works if turn off ASPM with module parameter aspm=0. > > In order to fix this problem kindly, this commit don't turn off aspm but > > enlarge ASPM L1 latency to 7. > > > > Reported-by: Jian-Hong Pan <jian-hong@xxxxxxxxxxxx> > > Tested-by: Jian-Hong Pan <jian-hong@xxxxxxxxxxxx> > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > This patch definitely needs a Cc for stable. Otherwise I ACK it. > Hi Larry, This patch had been applied by Greg, and CC'ed to stable. Thanks for your reminder. PK