Hi Dan,
On Thu, 5 Jul 2018 11:41:26 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Thu, Jul 05, 2018 at 09:18:53AM +0530, Ajay Singh wrote:
> > Fix for static checker warning inconsistent returns of
> > 'hif_deinit_lock'(more details [1]).
> >
> > "drivers/staging/wilc1000/host_interface.c:3390 wilc_deinit()
> > warn: inconsistent returns 'hif_deinit_lock'."
> >
> > Introduced in "ff52a57a7a42: staging: wilc1000: move the allocation
> > of cmd out of wilc_enqueue_cmd()".
>
> Can you use the Fixes tag so it's machine parseable?
>
> Fixes: ff52a57a7a42 ("staging: wilc1000: move the allocation of cmd
> out of wilc_enqueue_cmd()")
Thanks for your suggestion.
Will include the 'Fixes' tag and submit patch v2 version.
>
> With the fixes tag, say someone pulls ff52a57a7a42 into their code,
> they will know to pull this patch as well. Also scientists will be
> able to measure the time between bug and fix and write a scholarly
> paper about it.
>
> regards,
> dan carpenter
