Re: [PATCH v8] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

[Sven Eckelmann <sven.eckelmann@xxxxxxxxxxxx>]

On Mittwoch, 4. Juli 2018 11:29:53 CEST s.gottschall@xxxxxxxxxx wrote:
> +/* Values defined to set 160 MHz Bandwidth NSS Mapping into FW*/
> +#define BW_NSS_FWCONF_160(x)           (BW_NSS_FWCONF_MAP_ENABLE | \
> +                                       (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) \
> +                                       & BW_NSS_FWCONF_MAP_160MHZ_M))
> +#define BW_NSS_FWCONF_80_80(x)         (BW_NSS_FWCONF_MAP_ENABLE | \
> +                                       (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) \
> +                                       & BW_NSS_FWCONF_MAP_80_80MHZ_M))

Please check the shift and mask macros in core.h


#define BW_NSS_FWCONF_MAP_160MHZ_LSB           0
#define BW_NSS_FWCONF_MAP_160MHZ_MASK          0x00000007
#define BW_NSS_FWCONF_MAP_80_80MHZ_LSB         3
#define BW_NSS_FWCONF_MAP_80_80MHZ_MASK        0x00000038
#define BW_NSS_FWCONF_MAP_MASK                 0x0000003F

#define GET_BW_NSS_FWCONF_160(x)     (MS((x), BW_NSS_FWCONF_MAP_160MHZ) + 1)
#define GET_BW_NSS_FWCONF_80_80(x)   (MS((x), BW_NSS_FWCONF_MAP_80_80MHZ_M) + 1)

/* Values defined to set 160 MHz Bandwidth NSS Mapping into FW*/
#define BW_NSS_FWCONF_160(x)         (BW_NSS_FWCONF_MAP_ENABLE | \
                                      (SM((x) - 1, BW_NSS_FWCONF_MAP_160MHZ))
#define BW_NSS_FWCONF_80_80(x)       (BW_NSS_FWCONF_MAP_ENABLE | \
                                      (SM((x) - 1, BW_NSS_FWCONF_MAP_80_80MHZ))

(these snippets were not yet tested and most likely need further adjustments)


Kind regards,
	Sven

Attachment: signature.asc
Description: This is a digitally signed message part.