YueHaibing <yuehaibing@xxxxxxxxxx> writes: > 'firmware' is a module param which may been longer than firmware_id, > so using strlcpy() to guard against overflows. Also priv is allocated > with zeroed memory,no need to set firmware_id[0] to '\0'. > > v1 -> v2: remove priv->firmware_id[0] = '\0'; > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > drivers/net/wireless/atmel/atmel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) The changelog should be after "---" line. I can fix it this time, but in the future please use the correct location. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- Kalle Valo