Search Linux Wireless

Re: [PATCH 2/4] mac80211: Add api to configure low and high txrate threshold

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-06-13 at 16:28 +0530, Tamizh chelvam wrote:
> +	if (sta->txrate_low == low_txrate_thold &&
> +	    sta->txrate_high == high_txrate_thold)
> +		goto unlock;
> +
> +	sta->txrate_low = low_txrate_thold;
> +	sta->txrate_high = high_txrate_thold;

You don't really do anything here so what do you gain by doing the ==
comparison and jumping over the assignment?

I'd understand if you did some calculations here or whatever, but as it
is it reads more like something was missed than like it was intended
this way?

Again, I think you need to squash this with patch 4.

johannes



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux