On Wed, 2018-06-27 at 08:36 -0500, Larry Finger wrote: > On 06/27/2018 03:01 AM, pkshih@xxxxxxxxxxx wrote: > > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > > > rtl8821ae uses two kinds of firmwares for normal and WoWlan cases, and > > each firmware has firmware data buffer and size individually. Original > > code always overwrite size of normal firmware rtlpriv->rtlhal.fwsize, and > > this mismatch causes firmware checksum error, then firmware can't start. > > > > In this situation, driver gives message "Firmware is not ready to run!". > > > > Fixes: fe89707f0afa ("rtlwifi: rtl8821ae: Simplify loading of WOWLAN firmware") > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > --- > > v2: fix commit log typo. > > --- > > drivers/net/wireless/realtek/rtlwifi/core.c | 1 - > > 1 file changed, 1 deletion(-) > > This change is a good one, and I approve of it. The only change is that it > should have a Cc to stable as this code was added in kernel 4.0! > I'll Cc to stable in v3. Thanks PK