Hi Ganapathi, I love your patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.18-rc2 next-20180625] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ganapathi-Bhat/mwifiex-replace-rx_pkt_lock-by-rx_reorder_tbl_lock/20180625-175146 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: arm-sama5_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): In file included from include/linux/irqflags.h:16:0, from arch/arm/include/asm/bitops.h:28, from include/linux/bitops.h:38, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/wait.h:7, from drivers/net//wireless/marvell/mwifiex/decl.h:26, from drivers/net//wireless/marvell/mwifiex/11n_rxreorder.c:20: drivers/net//wireless/marvell/mwifiex/11n_rxreorder.c: In function 'mwifiex_11n_rx_reorder_pkt': >> arch/arm/include/asm/irqflags.h:171:2: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] asm volatile( ^~~ drivers/net//wireless/marvell/mwifiex/11n_rxreorder.c:155:16: note: 'flags' was declared here unsigned long flags; ^~~~~ -- In file included from include/linux/irqflags.h:16:0, from arch/arm/include/asm/bitops.h:28, from include/linux/bitops.h:38, from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/wait.h:7, from drivers/net/wireless/marvell/mwifiex/decl.h:26, from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:20: drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c: In function 'mwifiex_11n_rx_reorder_pkt': >> arch/arm/include/asm/irqflags.h:171:2: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] asm volatile( ^~~ drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:155:16: note: 'flags' was declared here unsigned long flags; ^~~~~ vim +/flags +171 arch/arm/include/asm/irqflags.h 7ad1bcb2 include/asm-arm/irqflags.h Russell King 2006-08-27 164 7ad1bcb2 include/asm-arm/irqflags.h Russell King 2006-08-27 165 /* 7ad1bcb2 include/asm-arm/irqflags.h Russell King 2006-08-27 166 * restore saved IRQ & FIQ state 7ad1bcb2 include/asm-arm/irqflags.h Russell King 2006-08-27 167 */ 6fb18ac9 arch/arm/include/asm/irqflags.h Daniel Thompson 2015-06-10 168 #define arch_local_irq_restore arch_local_irq_restore df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 169 static inline void arch_local_irq_restore(unsigned long flags) df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 170 { df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 @171 asm volatile( 55bdd694 arch/arm/include/asm/irqflags.h Catalin Marinas 2010-05-21 172 " msr " IRQMASK_REG_NAME_W ", %0 @ local_irq_restore" df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 173 : df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 174 : "r" (flags) df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 175 : "memory", "cc"); df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 176 } df9ee292 arch/arm/include/asm/irqflags.h David Howells 2010-10-07 177 :::::: The code at line 171 was first introduced by commit :::::: df9ee29270c11dba7d0fe0b83ce47a4d8e8d2101 Fix IRQ flag handling naming :::::: TO: David Howells <dhowells@xxxxxxxxxx> :::::: CC: David Howells <dhowells@xxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
