Search Linux Wireless

Re: [BUG] mac80211: Using smp_processor_id() in preemptible code: iwd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-06-15 at 11:09 +0000, McGinn, Dan wrote:
> Hi, I'm newly trying out Intel iwd daemon but I experience regular kernel errors in 4.17, although WPA2-PSK connection remains stable.  These errors don't seem to be experienced with wpa_supplicant.  The errors reliably appear around the following events:
> netdev_unicast_notify()
> netdev_control_port_frame_event()
> netdev_set_rekey_offload()
> netdev_set_gtk()
> 
> @Denkenz in IRC helpfully suggests Johannes could follow the finger of suspicion to this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=911806491425d79107cadddbde11b42bbdfe38c8

It's his code ;-)

Clearly this comes from cfg80211 without any locking other than rtnl, so
you don't have preemption disabled. That's the minimum needed to get rid
of the warning you found.

I was thinking this is also wrong because of locking assumptions, but I
don't see that in the code now, so I guess it's fine.

johannes



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux