Search Linux Wireless

Re: b43 crashes on rmmod (bcm4331)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

>>> Is is possible for you to create a git bisect to find the change that
>>> actually broke this?
>>> That would be really helpful.  
>>
>> I can try that.  What is the most efficient way to unload/recompile/load
>> a single module without rebooting the machine too often?  And it'll be a
>> lot of hard resets ...
> 
> A git bisect is really only possible in the full kernel tree.
> But it won't take a lot of steps to get a result, because you already
> narrowed it down to 4.14-4.15. It might take 10 iterations or so (git
> will tell you). Due to incremental builds that can be done pretty
> quickly. As the whole kernel is searched for a change, a reboot is
> usually needed after each iteration step.

Ah, yes.  I had for a moment thought I might get away with recompiling
just the b43 module, but that does not work of course.

I did the bisection, it was 13 steps.  My metric was to say 'modprobe
b43; rmmod b43'.  If the rmmod returns it's good, otherwise bad.  (I
booted every kernel only once, so I hope there is no randomness
involved.)  In the latter case the machine had to be hard-reset.  Also,
in the latter case 'lsmod | grep b43' returns after the failed rmmod:

b43                   348160  -1
ssb                    49152  1 b43
mac80211              688128  1 b43
cfg80211              540672  2 b43,mac80211
bcma                   49152  1 b43
led_class              16384  4 b43,applesmc,sdhci,input_leds

the bisection leads to

142a27f0a731ddcf467546960a5585970ca98e21 is the first bad commit
commit 142a27f0a731ddcf467546960a5585970ca98e21
Author: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>
Date:   Fri Oct 27 22:34:04 2017 +0530

    hwrng: core - Reset user selected rng by writing "" to rng_current

    User is able to select a chosen rng by writing its name to rng_current
    but there is no way to reset it without unbinding the rng. Let user
    write "" to rng_current and delesect the chosen rng.

    Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>
    reviewed-by: Harald Freudenberger <freude@xxxxxxxxxxxxxxxxxx>
    Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

:040000 040000 f61e5cc501c99fb09bae5f203528b9f4c3479f8a
785262813cfb02c9606fd72274f0f7b44f2289d7 M	drivers


cheers, lukas


-- 
Do not believe the naysayers who say it cannot be done.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux