Search Linux Wireless

Re: [PATCH 0/6] rtl8187: Adding Realtek rtl8187B support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 8, 2008 at 2:39 PM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> Hin-Tak,
>
> Good job getting these posted. For the first time in a long time, my unit
> was able to connect and authenticate. It certainly looks as if you solved
> the ep12 problem. I'm using the device to write this E-mail.

Very good! I am wondering about whether Pavel's negative experience came
from the accidental brokenness after tidy up. The clean version is so
obviously cleaner,
except it moved the management frame decision after skb_pull() which
munched skb.
That's so *unobvious* - I don't expect any structs with ->data, etc to
be mutate.

I only spotted the difference when I load the two modules one
after the other and I wasn't getting the same connectivity -
and looked at the diffs from usbmon in debugfs. (obviously
if I am sending in the patches I need to "eat-my-own-dog-food").

> Unfortunately, your mailer still wrapped some lines in the patches. It
> wasn't difficult to repair them, but it still is a bother. For the next
> round, we can work out a procedure that uses the mail utility to send the
> patches. I've used this method since Linville was unable to process my
> patches that were sent from Thunderbird.

Damn... Yes, I just looked at my gmail Sent folder and saw that.
What do people do to send in-line patches? I guess I have to learn to use
git-send-email properly. This is too hard :-).

> The patch to revise the detection of B units with an 8187 ID is ready. I can
> send it at any time.

Only you have the right hardware to test, so go ahead and post if you
are happy with the change.

Hin-Tak
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux