On Tuesday 08 July 2008 22:42:08 Christoph Hellwig wrote: > On Tue, Jul 08, 2008 at 01:49:31PM +0200, Johannes Berg wrote: > > Far too many people configure their kernel without CONFIG_KMOD > > and then complain that wireless breaks, thanks to Herbert Xu for > > pointing me to this. > > > > This patch makes CONFIG_KMOD default to "y" and adds a warning > > that people should not turn it off. > > What about just killing the config option entirely? It' basically > guarding a ~50 lines function + a sysctl variable. I think having > modules but not CONFIG_KMOD is entirely unreasonable. I agree with Christoph here. But as a patch series please: it's spread pretty wide. eg. first make it a non-prompting CONFIG option, then remove the users, then finally kill it. Some existing request_module users might be able to use try_then_request_module, too... Thanks! Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html