<pkshih@xxxxxxxxxxx> writes:
> From: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> The format of C2H data is ID(1 byte) + Length(1 byte) + value, and it is
> more readable to use macros to access C2H data.
>
> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
[...]
> --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h
> @@ -177,6 +177,11 @@ enum rtl_c2h_evt_v2 {
> C2H_V2_CCX_RPT = 0x0F,
> };
>
> +#define GET_C2H_CMD_ID(c2h) ({u8 *__c2h = c2h; __c2h[0]; })
> +#define GET_C2H_SEQ(c2h) ({u8 *__c2h = c2h; __c2h[1]; })
> +#define C2H_DATA_OFFSET 2
> +#define GET_C2H_DATA_PTR(c2h) ({u8 *__c2h = c2h; &__c2h[C2H_DATA_OFFSET]; })
These macros are not really pretty, a proper static inline function
would be a much better choise. But I'm planning to apply this patch
anyway, I don't think it's a blocker but a good idea to cleanup later.
And rtlwifi really should get away with this foo[0] and foo[1] style of
buffers and switch to proper structs (foo->bar and foo->koo).
--
Kalle Valo
