Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes: > Maya Erez <merez@xxxxxxxxxxxxxx> writes: > >> From: Gidon Studinski <gidons@xxxxxxxxxxxxxx> >> >> Enhanced DMA design includes the following rings: >> - Single RX descriptor ring is used for all VIFs >> - Multiple RX status rings are supported, to allow RSS >> - TX descriptor ring is allocated per connection >> - A single TX status ring is used for all TX descriptor rings >> >> This patch initializes and frees the above descriptor and >> status rings. >> >> The RX SKBs are handled by a new entity of RX buffers manager, >> which handles RX buffers, each one points to an allocated SKB. >> During Rx completion processing, the driver extracts a buffer >> ID which is used as an index to the buffers array. >> After the SKB is freed the buffer is moved from the 'active' >> list to the 'free' list, indicating it can be used for another >> descriptor. During Rx refill, SKBs are allocated and attached >> to 'free' buffers. Those buffers are attached to new descriptors >> and moved to the 'active' list. >> >> Signed-off-by: Gidon Studinski <gidons@xxxxxxxxxxxxxx> >> Signed-off-by: Maya Erez <merez@xxxxxxxxxxxxxx> > > [...] > >> --- a/drivers/net/wireless/ath/wil6210/pcie_bus.c >> +++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c >> @@ -32,6 +32,10 @@ >> module_param(ftm_mode, bool, 0444); >> MODULE_PARM_DESC(ftm_mode, " Set factory test mode, default - false"); >> >> +static bool use_enhanced_dma_hw = true; >> +module_param(use_enhanced_dma_hw, bool, 0444); >> +MODULE_PARM_DESC(use_enhanced_dma_hw, " Use enhanced or legacy DMA HW. Default: true when available"); > > Similarly as with debugfs, please document in the commit log any changes > in module parameters. Oh, and in this patch there are even more new module parameters and no mention them in the commit log. But a bigger problem is that wil6210 has now 24 module parameters (with this patchset included). That is quite a lot, are those all really needed? Module parameters are bad user experience and there should be good reasons before adding them. -- Kalle Valo
