* Reizer, Eyal <eyalr@xxxxxx> [180523 12:45]: > > > > > > > > Here's a modified version of your patch, does that put wlcore to > > > idle with wowlan during suspend for you? > > > > > > > Still no joy. > > It suspends/resumes ok but leaves the firmware disabled from entering ELP. > > Spent some time on it today and looks like adding calls to pm_generic_runtime_suspend () > And pm_generic_runtime_resume is helping and all seems to work well. Oh right yeah you got it, I totally forgot about those. > See the modified version of your patch below. > Let me know what you think. Looks good to me, one comment below.. > - wlcore_fw_sleep(wl); > + spin_lock_irqsave(&wl->wl_lock, flags); > + set_bit(WL1271_FLAG_SUSPENDED, &wl->flags); > + spin_unlock_irqrestore(&wl->wl_lock, flags); > + > + pm_generic_runtime_suspend(wl->dev); > > return 0; Maybe just return pm_generic_runtime_suspend(wl->dev) here? > @@ -1845,6 +1816,8 @@ static int wl1271_op_resume(struct ieee80211_hw *hw) > wl->wow_enabled); > WARN_ON(!wl->wow_enabled); > > + pm_generic_runtime_resume(wl->dev); > + And add error handling to pm_generic_runtime_resume(wl->dev) here? Then if you can please post your patch with proper Signed-off-by I'll add it to my set and repost v3 of all the patches :) Regards, Tony
