On Sun 25 Mar 22:41 PDT 2018, Govind Singh wrote:
> Add support for host capablity request
> qmi message for wcn3990 target.
>
> Signed-off-by: Govind Singh <govinds@xxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath10k/qmi.c | 65 +++++++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
> index 65a43af..a33681d 100644
> --- a/drivers/net/wireless/ath/ath10k/qmi.c
> +++ b/drivers/net/wireless/ath/ath10k/qmi.c
> @@ -357,6 +357,67 @@ static int ath10k_qmi_cap_send_sync_msg(struct ath10k_qmi *qmi)
> return ret;
> }
>
> +static int ath10k_qmi_host_cap_send_sync(struct ath10k_qmi *qmi)
> +{
> + struct wlfw_host_cap_resp_msg_v01 *resp;
This is 4 bytes,
> + struct wlfw_host_cap_req_msg_v01 *req;
and this is 2 bytes, use the stack.
> + struct qmi_txn txn;
> + int ret;
> +
> + req = kzalloc(sizeof(*req), GFP_KERNEL);
> + if (!req)
> + return -ENOMEM;
> +
> + resp = kzalloc(sizeof(*resp), GFP_KERNEL);
> + if (!resp) {
> + kfree(req);
> + return -ENOMEM;
> + }
> +
> + req->daemon_support_valid = 1;
> + req->daemon_support = 0;
> +
> + pr_debug("daemon_support is %d\n", req->daemon_support);
This print seems unnecessary.
> +
> + ret = qmi_txn_init(&qmi->qmi_hdl, &txn,
> + wlfw_host_cap_resp_msg_v01_ei, resp);
> + if (ret < 0) {
> + pr_err("Fail to init txn for Capability resp %d\n", ret);
Same comments the rest of the function as given on previous patches.
> + goto out;
> + }
Regards,
Bjorn
