On Thu, 10 May 2018 11:24:12 +0100 Matt Redfearn <matt.redfearn@xxxxxxxx> wrote: > > Could you please try this? > > > > config SSB_DRIVER_PCICORE_POSSIBLE > > depends on SSB_PCIHOST > > > > config SSB_PCICORE_HOSTMODE > > depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && (SSB = y) && PCI_DRIVERS_LEGACY > > > > > > The affected API pcibios_enable_device() and register_pci_controller() > > is only used in HOSTMODE. So I think it makes sense to make HOSTMODE > > depend on SSB=y and PCI_DRIVERS_LEGACY. > > > > PCICore itself does not use the API, if hostmode is disabled. > > > > Sure - I've tested the patch: > > --- a/drivers/ssb/Kconfig > +++ b/drivers/ssb/Kconfig > @@ -117,7 +117,7 @@ config SSB_SERIAL > > config SSB_DRIVER_PCICORE_POSSIBLE > bool > - depends on SSB_PCIHOST && SSB = y > + depends on SSB_PCIHOST > default y > > config SSB_DRIVER_PCICORE > @@ -131,7 +131,7 @@ config SSB_DRIVER_PCICORE > > config SSB_PCICORE_HOSTMODE > bool "Hostmode support for SSB PCI core" > - depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS > + depends on SSB_DRIVER_PCICORE && SSB_DRIVER_MIPS && (SSB = y) && > PCI_DRIVERS_LEGACY > help > PCIcore hostmode operation (external PCI bus). > > > And this seems to work for MIPS, we don't get the build error from > building the SSB module under nec_markeins allmodconfig, and > SSB_PCICORE_HOSTMODE=y for bcm47xx allmodconfig, which selects SSB=y. > > So this looks like a good fix for MIPS, at least. > > Tested-by: Matt Redfearn <matt.redfearn@xxxxxxxx> Thanks. Could you please submit it? You can add my Acked-by. -- Michael
Attachment:
pgpjhSW0jOGzy.pgp
Description: OpenPGP digital signature
