Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >> WARN_ON is used where the function has no way to signal errors to the >> caller. > > There isn't really much point in that - failing allocations are already > *very* noisy. Please respin with that removed (and then I guess you can > fix the Fixes: too) OK, will do. > You didn't actually do that in this patch though :-) Well, I may have copy-pasted that from the commit message of the previous patch ;) > It's bool so you don't need the !!(...) :-) But what if I want it to be extra super duper bool? ;) -Toke
