On Sat, 2008-07-05 at 21:26 +0200, Ivo van Doorn wrote: > On Saturday 05 July 2008, Johannes Berg wrote: > > > > > Hmm, in that case I have to fix something in the beacondone handler > > > to prevent it requesting a beacon when mac80211 hasn't supplied anything > > > yet.. > > > > I was working in this area... Can you take a quick look at this patch > > and let me know what you think? > > http://johannes.sipsolutions.net/patches/kernel/all/2008-07-05-18%3a42/mac80211-beacon-revamp.patch > > Patch looks good to me, it wouldn't change anything about the above since t2x00 would still > call ieee80211_beacon_get() when the beacon wasn't provided by mac80211 yet. Oh, of course, I just was writing on the patch and read your mail and replied instead of sending you another one :) One thing I'm worried about is the sequence numbers, but that bug is already there... IIRC you needed software sequence numbers for your drivers, but what about the beacons? I haven't _changed_ anything, but IBSS beacons seem to not get a software sequence number. > But the flags that mark what has changed is definately a good idea, > that will prevent some redundant register writes. :) :) Only once you use the flags. My patch is intentionally minimal. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
