On Mon, Apr 23, 2018 at 04:12:01PM -0400, Andres Rodriguez wrote:
> diff --git a/include/linux/firmware.h b/include/linux/firmware.h
> index db8351a42405..a34e16f77f20 100644
> --- a/include/linux/firmware.h
> +++ b/include/linux/firmware.h
> @@ -42,6 +42,8 @@ struct builtin_fw {
> #if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE))
> int firmware_request(const struct firmware **fw, const char *name,
> struct device *device);
> +int firmware_request_nowarn(const struct firmware **fw, const char *name,
> + struct device *device);
> int firmware_request_nowait(
> struct module *module, bool uevent,
> const char *name, struct device *device, gfp_t gfp, void *context,
You also missed the firmware_request_nowarn() call on the #else. I'll add it
and re-submit myself.
In future patches about firmware please also Cc Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>,
and Kees Cook <keescook@xxxxxxxxxxxx>. You can also use the long list (modulo, not
the EFI list) that Hans used on his EFI patches. I realize its long but its just
to ensure enough folks get to review and eybeball the code.
Luis
