On Tue, May 01, 2018 at 05:44:19AM +0530, Sriram R wrote: > On 2018-05-01 05:14, Sriram R wrote: > > On 2018-05-01 00:39, Greg KH wrote: > > > On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote: > > > > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > > > > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > > > > on host (mac80211) rather than firmware. Rebuild cipher header > > > > in every received data frames (that are notified through those > > > > HTT interfaces) from the rx_hdr_status tlv available in the > > > > rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED > > > > flag for the packets which requires mac80211 PN/TSC check support > > > > and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X, > > > > and QCA99X0 currently need the rebuilding of cipher header to > > > > perform PN/TSC check for replay attack. > > > > > > > > [Upstream Commit : 7eccb738fce57cbe53ed903ccf43f9ab257b15b3] > > > > > > > > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@xxxxxxxxxxxxxx> > > > > Signed-off-by: Sriram R <srirrama@xxxxxxxxxxxxxx> > > > > --- > > > > drivers/net/wireless/ath/ath10k/htt_rx.c | 98 > > > > ++++++++++++++++++++++++++------ > > > > 1 file changed, 82 insertions(+), 16 deletions(-) > > > > > > This patch breaks the build. Always test build your patches! > > > > > > thanks, > > > > > > greg k-h > > Hi Greg, > > > > This patch along with its dependency patches (in the following order) > > > > f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW > > crypto > > f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames > > cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped > > [PATCH 1/2 linux-stable-4.4] ath10k: Add new hw param to identify > > alignment for different chipsets > > > Hi Greg, > > I feel this breaks since the above mentioned mac80211 commits are not > available in this queue. > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-4.4/series?id=8e2985dd801f00640be6998ec831018a688bb221 > > Could you please check after these commits are queued as well before this > patch is applied. > > Please let me know if i miss something here so i could check from my side as > well. Ugh, you are right, I missed that in the cover leter, my fault. I'll blame the jet-lag :) I'll go drop the first patch for now, and then look at all of these again at the end of the week for the next round of releases. thanks, greg k-h