On 04/22/2018 02:15 PM, Roopa Prabhu wrote:
On Sun, Apr 22, 2018 at 11:54 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Thu, 19 Apr 2018 17:26:57 +0200
On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote:
Maybe this could be in followup patches? It's going to touch a lot of files,
and might be hell to get merged all at once, and I've never used spatch, so
just maybe someone else will volunteer that part :)
I guess you'll have to ask davem. :)
Well, first of all, I really don't like this.
The first reason is that every time I see interface foo become foo2,
foo3 is never far behind it.
If foo was not extensible enough such that we needed foo2, we beter
design the new thing with explicitly better extensibility in mind.
Furthermore, what you want here is a specific filter. Someone else
will want to filter on another criteria, and the next person will
want yet another.
This needs to be properly generalized.
And frankly if we had moved to ethtool netlink/devlink by now, we
could just add a netlink attribute for filtering and not even be
having this conversation.
+1.
Also, the RTM_GETSTATS api was added to improve stats query efficiency
(with filters).
we should look at it to see if this fits there. Keeping all stats
queries in one place will help.
I like the ethtool API, so I'll be sticking with that for now.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
