On Mon, 2018-04-23 at 15:39 +0300, Luciano Coelho wrote: > On Mon, 2018-04-23 at 15:05 +0300, Mika Westerberg wrote: > > Hi, > > Hi Mika, > > > > On my Lenovo X1 Carbon gen 5 system,after I upgraded to v4.17-rc1 > > iwlwifi started to fail with following splats on dmesg: > > > > iwlwifi 0000:04:00.0: Microcode SW error detected. Restarting > > 0x2000000. > > iwlwifi 0000:04:00.0: Start IWL Error Log Dump: > > iwlwifi 0000:04:00.0: Status: 0x00000100, count: 6 > > iwlwifi 0000:04:00.0: Loaded firmware version: 31.560484.0 > > iwlwifi 0000:04:00.0: 0x00000038 | BAD_COMMAND > > [...] > > > The controller in question is: > > > > 04:00.0 Network controller [0280]: Intel Corporation Wireless > > 8265 > > / 8275 [8086:24fd] (rev 88) > > > > Bisection pointed to the following commit and after I reverted it, > > things seem to work fine again: > > > > 66fa2424df16 ("iwlwifi: fw api: support the new scan request FW > > API > > version") > > > > Any idea what might be wrong with that commit and how to fix it > > properly? > > We had a bug in the scan command size for older firmwares. I have > already made a fix for it, but I hadn't sent it out for upstream > yet. > I'll send it out now and soon send you a link to it in patchwork. Here's the patch that solves the problem with older FWs: https://patchwork.kernel.org/patch/10356987/ -- Cheers, Luca.